issue1100 #1320
Merged
issue1100 #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block config:
```
{
"_id": "b-05",
"_parentId": "a-05",
"_type": "block",
"_classes": "animated",
"title": "b-05",
"displayTitle": "",
"body": "",
"_trackingId": 0,
"_onScreen": {
"_isEnabled": true,
"_classes": "wobble",
"_percentInviewVertical": 50
}
}
```
Disabled by default.
oliverfoster
approved these changes
Nov 17, 2016
| setupOnScreenHandler: function() { | ||
| var onscreen = this.model.get('_onScreen'); | ||
|
|
||
| if (onscreen && onscreen._isEnabled) { |
There was a problem hiding this comment.
Would you mind terribly reversing the logic here so we can sink the indentation?
if (!onscreen || !onscreen._isEnabled) return;…ed for every article/block/component
lc-thomasberger
force-pushed
the
issue/1100
branch
from
1a5e9dd to
9316b69
Compare
oliverfoster
approved these changes
Nov 17, 2016
tomgreenfield
approved these changes
Nov 17, 2016
oliverfoster
requested changes
Nov 21, 2016
|
|
||
| if (!onscreen || !onscreen._isEnabled) return; | ||
|
|
||
| this.$el.on('onscreen', _.bind(function (e, m) { |
There was a problem hiding this comment.
can you change this to this.$el('onscreen.adaptView'?
|
|
||
| if (m.percentInviewVertical < minVerticalInview) return; | ||
|
|
||
| this.$el.addClass( onscreen._classes || 'onscreen' ).off('onscreen'); |
There was a problem hiding this comment.
can you change this to .off('onscreen.adaptView');?
| @@ -93,6 +112,7 @@ define([ | |||
| }, | |||
|
|
|||
| remove: function() { | |||
| this.$el.off('onscreen'); | |||
There was a problem hiding this comment.
can you change this to .off('onscreen.adaptView')?
brian-learningpool
approved these changes
Nov 21, 2016
oliverfoster
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update blockView to add css class if element is onScreen.
Block config:
Disabled by default.
The block config shows example using animate.css animtions.